feat: do not emit initial navigation events #2796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
added
DO NOT MERGE
OrKoN
reviewed
Nov 21, 2024
sadym-chromium
force-pushed
the
sadym/initial-navigation
branch
2 times, most recently
from
b1fd7dc to
8c346fe
Compare
sadym-chromium
force-pushed
the
sadym/initial-navigation
branch
2 times, most recently
from
c99615f to
1f33f2c
Compare
sadym-chromium
force-pushed
the
sadym/initial-navigation
branch
from
2c1da8e to
35bc062
Compare
sadym-chromium
force-pushed
the
sadym/initial-navigation
branch
from
258a2e6 to
83c18d4
Compare
|
Oh so it even fixes some Puppeteer tests, cool! |
OrKoN
approved these changes
Nov 22, 2024
sadym-chromium
pushed a commit
that referenced
this pull request
Nov 25, 2024
🤖 I have created a release *beep* *boop* --- ## [0.10.1](chromium-bidi-v0.10.0...chromium-bidi-v0.10.1) (2024-11-25) ### Features * do not emit initial navigation events ([#2796](#2796)) ([c8c9cdf](c8c9cdf)) * implement `browser.getClientWindows` ([#2780](#2780)) ([7b91906](7b91906)) ### Bug Fixes * `browser.getClientWindows` returns a unique per window value ([#2783](#2783)) ([0f97130](0f97130)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #2793
PR updating WPT: web-platform-tests/wpt#49327