feat(add intercept): address global intercepts #1518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
This will fix some WPT tests, however I'll need to first make a change in the tests because some of its set-up code is introducing side-effects, blocking requests too early. |
thiagowfx
force-pushed
the
thiagowfx/intercept
branch
from
0354d2d to
1dd932e
Compare
Lightning00Blade
approved these changes
Nov 2, 2023
Whenever no patterns are specified in BiDi, omit the "patterns" parameter in "Fetch.enable", in order to match all requests: > If specified, only requests matching any of these patterns will produce fetchRequested event and will be paused until clients response. If not set, all requests will be affected. Bug: #644 Docs: https://chromedevtools.github.io/devtools-protocol/tot/Fetch/#method-enable
thiagowfx
force-pushed
the
thiagowfx/intercept
branch
from
1dd932e to
f5b054c
Compare
|
This approach does not work. |
|
Closing in favour of #1530 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever no patterns are specified in BiDi, omit the "patterns" parameter in "Fetch.enable", in order to match all requests:
Bug: #644
Docs: https://chromedevtools.github.io/devtools-protocol/tot/Fetch/#method-enable