Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement dedicated workers #1565

Merged
merged 3 commits into from
Nov 17, 2023
Merged

feat: implement dedicated workers #1565

merged 3 commits into from
Nov 17, 2023

Conversation

jrandolf-2
Copy link
Contributor

No description provided.

@jrandolf-2 jrandolf-2 requested a review from OrKoN November 17, 2023 07:57
@jrandolf-2 jrandolf-2 force-pushed the jrandolf/worker branch 2 times, most recently from 1396f4e to bb1033d Compare November 17, 2023 08:02
@jrandolf-2 jrandolf-2 requested a review from OrKoN November 17, 2023 09:03
@jrandolf-2 jrandolf-2 force-pushed the jrandolf/worker branch 3 times, most recently from 32e63d9 to efcdb68 Compare November 17, 2023 09:09
@jrandolf-2 jrandolf-2 requested a review from OrKoN November 17, 2023 10:29
@jrandolf-2 jrandolf-2 force-pushed the jrandolf/worker branch 3 times, most recently from d14054d to 7f98fa0 Compare November 17, 2023 11:34
Copy link
Collaborator

@OrKoN OrKoN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@jrandolf-2 jrandolf-2 merged commit 8312aff into main Nov 17, 2023
11 of 13 checks passed
@jrandolf-2 jrandolf-2 deleted the jrandolf/worker branch November 17, 2023 12:48
sadym-chromium added a commit that referenced this pull request Nov 17, 2023
sadym-chromium added a commit that referenced this pull request Nov 17, 2023
Reverts #1565

e2e tests started constantly timing out.
sadym-chromium pushed a commit that referenced this pull request Nov 17, 2023
##
[0.5.0](chromium-bidi-v0.4.34...chromium-bidi-v0.5.0)
(2023-11-17)


### ⚠ BREAKING CHANGES

* `BidiServer.createAndStart` signature changed. New optional parameter
`options` is added. Breaking change for Puppeteer, while ChromeDriver is
not affected, as it uses the Mapper Tab.

### Features

* `acceptInsecureCerts`
([#1553](#1553))
([8a13940](8a13940))
* implement dedicated workers
([#1565](#1565))
([8312aff](8312aff))


### Bug Fixes

* do not wait during browsingContext.traverseHistory
([#1557](#1557))
([aaf45a2](aaf45a2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants