-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement dedicated workers #1565
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrandolf-2
force-pushed
the
jrandolf/worker
branch
2 times, most recently
from
November 17, 2023 08:02
1396f4e
to
bb1033d
Compare
OrKoN
reviewed
Nov 17, 2023
OrKoN
reviewed
Nov 17, 2023
OrKoN
reviewed
Nov 17, 2023
OrKoN
reviewed
Nov 17, 2023
jrandolf-2
force-pushed
the
jrandolf/worker
branch
from
November 17, 2023 09:03
6cf6b58
to
70482ec
Compare
jrandolf-2
force-pushed
the
jrandolf/worker
branch
3 times, most recently
from
November 17, 2023 09:09
32e63d9
to
efcdb68
Compare
OrKoN
reviewed
Nov 17, 2023
OrKoN
reviewed
Nov 17, 2023
OrKoN
reviewed
Nov 17, 2023
jrandolf-2
force-pushed
the
jrandolf/worker
branch
from
November 17, 2023 10:14
efcdb68
to
bddff09
Compare
jrandolf-2
force-pushed
the
jrandolf/worker
branch
3 times, most recently
from
November 17, 2023 11:34
d14054d
to
7f98fa0
Compare
OrKoN
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks
jrandolf-2
force-pushed
the
jrandolf/worker
branch
from
November 17, 2023 12:46
7f98fa0
to
6e4a13d
Compare
sadym-chromium
added a commit
that referenced
this pull request
Nov 17, 2023
This reverts commit 8312aff.
sadym-chromium
added a commit
that referenced
this pull request
Nov 17, 2023
Reverts #1565 e2e tests started constantly timing out.
sadym-chromium
pushed a commit
that referenced
this pull request
Nov 17, 2023
## [0.5.0](chromium-bidi-v0.4.34...chromium-bidi-v0.5.0) (2023-11-17) ### ⚠ BREAKING CHANGES * `BidiServer.createAndStart` signature changed. New optional parameter `options` is added. Breaking change for Puppeteer, while ChromeDriver is not affected, as it uses the Mapper Tab. ### Features * `acceptInsecureCerts` ([#1553](#1553)) ([8a13940](8a13940)) * implement dedicated workers ([#1565](#1565)) ([8312aff](8312aff)) ### Bug Fixes * do not wait during browsingContext.traverseHistory ([#1557](#1557)) ([aaf45a2](aaf45a2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.