Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add temp context into worker realm for Puppeteer #1801

Merged
merged 1 commit into from
Jan 31, 2024
Merged

feat: add temp context into worker realm for Puppeteer #1801

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/bidiMapper/domains/script/DedicatedWorkerRealm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,15 @@ export class DedicatedWorkerRealm extends Realm {
return 'dedicated-worker';
}

override get source(): Script.Source {
return {
realm: this.realmId,
// This is a hack to make Puppeteer able to track workers.
// TODO: remove after Puppeteer tracks workers by owners and use the base version.
context: this.associatedBrowsingContexts[0]?.id,
};
}

override get realmInfo(): Script.DedicatedWorkerRealmInfo {
return {
...this.baseInfo,
Expand Down
Loading