-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: initial implementation for the Web Bluetooth spec #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/bluetooth
branch
2 times, most recently
from
March 27, 2024 09:35
e6bb2e0
to
6b79524
Compare
Lightning00Blade
force-pushed
the
orkon/bluetooth
branch
from
March 27, 2024 20:02
6b79524
to
c889953
Compare
@OrKoN rebased + small change. |
OrKoN
commented
Mar 27, 2024
OrKoN
changed the title
chore: generated files for the Web Bluetooth spec
feat: implement Web Bluetooth spec
Aug 13, 2024
OrKoN
force-pushed
the
orkon/bluetooth
branch
2 times, most recently
from
August 13, 2024 16:35
d7ac42f
to
484034e
Compare
OrKoN
force-pushed
the
orkon/bluetooth
branch
2 times, most recently
from
September 4, 2024 16:58
2c68544
to
2c987bb
Compare
@alexnj it looks like handleDevicePrompt should work as it only passed the ids down to CDP https://github.com/GoogleChromeLabs/chromium-bidi/pull/2060/files#diff-72654de89f8552b0cde4fea49eda0b5bd82dc3be3364aaa11dbbed03db83cc4dR52 |
OrKoN
force-pushed
the
orkon/bluetooth
branch
from
September 5, 2024 07:01
a76b7e7
to
e0e8487
Compare
OrKoN
commented
Sep 5, 2024
OrKoN
commented
Sep 5, 2024
OrKoN
changed the title
feat: implement Web Bluetooth spec
feat: initial implementation for the Web Bluetooth spec
Sep 5, 2024
…romptOpened (#2548) This PR adds a test for `bluetooth.requestDevicePromptOpened` permissions API using the new `BluetoothEmulation` CDP domain commands. Please give it a review, and once in reasonable shape we can add tests for any additional APIs. --------- Co-authored-by: Maksim Sadym <sadym@chromium.org>
OrKoN
force-pushed
the
orkon/bluetooth
branch
from
September 5, 2024 07:15
64983b5
to
4dd40df
Compare
sadym-chromium
approved these changes
Sep 5, 2024
Lightning00Blade
pushed a commit
that referenced
this pull request
Sep 16, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.1](chromium-bidi-v0.7.0...chromium-bidi-v0.7.1) (2024-09-16) ### Features * initial implementation for the Web Bluetooth spec ([#2060](#2060)) ([ecb18d3](ecb18d3)) * support ESM module ([#2451](#2451)) ([662a857](662a857)) * support network.setCacheBehavior ([#2593](#2593)) ([75ba46c](75ba46c)) * support only statusCode in continueResponse ([#2598](#2598)) ([1eeff5b](1eeff5b)) ### Bug Fixes * add bluetooth command parser and fix tests ([#2589](#2589)) ([98ad2d9](98ad2d9)) * clear the buffered logs when browsing context is destroyed ([#2592](#2592)) ([36fb707](36fb707)), closes [#475](#475) * provide invalid set cache props ([#2590](#2590)) ([0830f00](0830f00)) * **spec:** update WebBluetooth implementation to match the latest spec ([#2588](#2588)) ([ec1ab96](ec1ab96)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements Web Bluetooth specification for WebDriver BiDi using CDP.