Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial implementation for the Web Bluetooth spec #2060

Merged
merged 7 commits into from
Sep 5, 2024
Merged

Conversation

OrKoN
Copy link
Collaborator

@OrKoN OrKoN commented Mar 22, 2024

This PR implements Web Bluetooth specification for WebDriver BiDi using CDP.

@OrKoN OrKoN marked this pull request as draft March 22, 2024 08:28
@OrKoN OrKoN force-pushed the orkon/bluetooth branch from d0d48d3 to 4fcf84b Compare March 26, 2024 09:27
@OrKoN OrKoN force-pushed the orkon/bluetooth branch 2 times, most recently from e6bb2e0 to 6b79524 Compare March 27, 2024 09:35
@Lightning00Blade
Copy link
Collaborator

Lightning00Blade commented Mar 27, 2024

@OrKoN rebased + small change.

@OrKoN OrKoN changed the title chore: generated files for the Web Bluetooth spec feat: implement Web Bluetooth spec Aug 13, 2024
@OrKoN OrKoN force-pushed the orkon/bluetooth branch 2 times, most recently from d7ac42f to 484034e Compare August 13, 2024 16:35
@OrKoN OrKoN force-pushed the orkon/bluetooth branch 2 times, most recently from 2c68544 to 2c987bb Compare September 4, 2024 16:58
@OrKoN
Copy link
Collaborator Author

OrKoN commented Sep 4, 2024

@alexnj it looks like handleDevicePrompt should work as it only passed the ids down to CDP https://github.com/GoogleChromeLabs/chromium-bidi/pull/2060/files#diff-72654de89f8552b0cde4fea49eda0b5bd82dc3be3364aaa11dbbed03db83cc4dR52

src/bidiMapper/BidiServer.ts Outdated Show resolved Hide resolved
@OrKoN OrKoN marked this pull request as ready for review September 5, 2024 07:02
@OrKoN OrKoN requested a review from sadym-chromium September 5, 2024 07:02
@OrKoN OrKoN changed the title feat: implement Web Bluetooth spec feat: initial implementation for the Web Bluetooth spec Sep 5, 2024
OrKoN and others added 7 commits September 5, 2024 09:15
…romptOpened (#2548)

This PR adds a test for `bluetooth.requestDevicePromptOpened`
permissions API
using the new `BluetoothEmulation` CDP domain commands.

Please give it a review, and once in reasonable shape we can add tests
for any
additional APIs.

---------

Co-authored-by: Maksim Sadym <sadym@chromium.org>
@OrKoN OrKoN merged commit ecb18d3 into main Sep 5, 2024
49 checks passed
@OrKoN OrKoN deleted the orkon/bluetooth branch September 5, 2024 07:42
Lightning00Blade pushed a commit that referenced this pull request Sep 16, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.7.1](chromium-bidi-v0.7.0...chromium-bidi-v0.7.1)
(2024-09-16)


### Features

* initial implementation for the Web Bluetooth spec
([#2060](#2060))
([ecb18d3](ecb18d3))
* support ESM module
([#2451](#2451))
([662a857](662a857))
* support network.setCacheBehavior
([#2593](#2593))
([75ba46c](75ba46c))
* support only statusCode in continueResponse
([#2598](#2598))
([1eeff5b](1eeff5b))


### Bug Fixes

* add bluetooth command parser and fix tests
([#2589](#2589))
([98ad2d9](98ad2d9))
* clear the buffered logs when browsing context is destroyed
([#2592](#2592))
([36fb707](36fb707)),
closes
[#475](#475)
* provide invalid set cache props
([#2590](#2590))
([0830f00](0830f00))
* **spec:** update WebBluetooth implementation to match the latest spec
([#2588](#2588))
([ec1ab96](ec1ab96))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants