fix: report correct value for DefaultValue in UserPrompt #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
approved these changes
May 23, 2024
Lightning00Blade
changed the title
Lightning00Blade
force-pushed
the
report-correct-user-prompt-value
branch
from
ddb09d6 to
4c0661f
Compare
sadym-chromium
approved these changes
May 24, 2024
Signed-off-by: Browser Automation Bot <browser-automation-bot@google.com>
Lightning00Blade
force-pushed
the
report-correct-user-prompt-value
branch
from
1e264b4 to
781a662
Compare
Lightning00Blade
pushed a commit
that referenced
this pull request
May 31, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.20](chromium-bidi-v0.5.19...chromium-bidi-v0.5.20) (2024-05-31) ### Features * send `browsingContext.contextCreated` event while subscribing ([#2255](#2255)) ([592c839](592c839)) * support document as `startNodes` in `browsingContext.locateNodes` ([#2218](#2218)) ([ad7318f](ad7318f)) * support for graphemes in key input ([#2207](#2207)) ([8e3a6c0](8e3a6c0)) ### Bug Fixes * added missing input transformations ([#2186](#2186)) ([ea48dc2](ea48dc2)) * css locator should allow nodes to be start nodes ([#2195](#2195)) ([4a361a5](4a361a5)) * errors for `input.setFile` ([#2232](#2232)) ([49e3712](49e3712)) * expose the override data to the request events ([#2241](#2241)) ([947bb8e](947bb8e)) * report correct value for DefaultValue in UserPrompt ([#2228](#2228)) ([df5ebf6](df5ebf6)) * screenshot taken in scrolled viewport origin ([#2161](#2161)) ([b3c57c8](b3c57c8)) * throw invalid argument for header ([#2246](#2246)) ([664d043](664d043)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: web-platform-tests/wpt#46441, this need to be merged else test will fail.
Also make the test run in CI.