fix: wait for default realm to be created before evaluating script #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
force-pushed
the
sadym/default_realm
branch
from
8f039fa to
9208974
Compare
sadym-chromium
force-pushed
the
sadym/default_realm
branch
from
a6fed6b to
5432623
Compare
OrKoN
force-pushed
the
sadym/default_realm
branch
from
5432623 to
2b6f973
Compare
OrKoN
approved these changes
Jun 7, 2024
sadym-chromium
pushed a commit
that referenced
this pull request
Jun 7, 2024
🤖 I have created a release *beep* *boop* --- ## [0.5.21](chromium-bidi-v0.5.20...chromium-bidi-v0.5.21) (2024-06-07) ### Features * restore frame tree when reconnecting to browser ([#2289](#2289)) ([f7a0c75](f7a0c75)) * support creating tab in background ([#2262](#2262)) ([e7c4b42](e7c4b42)) ### Bug Fixes * validate HTTP method ([#2284](#2284)) ([a22694a](a22694a)) * wait for default realm to be created before evaluating script ([#2294](#2294)) ([444e728](444e728)) * when reconnecting, save context's url ([#2276](#2276)) ([9585138](9585138)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #2275.
Cannot reproduce in nodejs or chromedriver runners.