Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor local http server #2368

Merged
merged 3 commits into from
Jul 2, 2024
Merged

test: refactor local http server #2368

merged 3 commits into from
Jul 2, 2024

Conversation

sadym-chromium
Copy link
Collaborator

  • Hide httpserver in the LocalHttpServer.
  • Unify url fixtures names.
  • Add url_bad_ssl to LocalHttpServer.

@sadym-chromium sadym-chromium mentioned this pull request Jul 1, 2024
Merged
@Lightning00Blade
Copy link
Collaborator

@sadym-chromium The E2E test are failing will review once the test pass as this should be a no-op change.

@sadym-chromium sadym-chromium force-pushed the sadym/service_workers branch from c2247a3 to f7b9dd6 Compare July 2, 2024 07:17
@sadym-chromium sadym-chromium force-pushed the sadym/service_workers branch from 59e4336 to 5dbd158 Compare July 2, 2024 08:22
@sadym-chromium
Copy link
Collaborator Author

@sadym-chromium The E2E test are failing will review once the test pass as this should be a no-op change.

done

@sadym-chromium sadym-chromium merged commit 170fcf1 into main Jul 2, 2024
48 checks passed
@sadym-chromium sadym-chromium deleted the sadym/service_workers branch July 2, 2024 08:39
sadym-chromium added a commit that referenced this pull request Jul 2, 2024
@sadym-chromium
fix: the capability to ignore cert errors should be browser-wide (#2369)
6db665b 
Addressing #2357
* Fix the root cause.
* Add e2e.

Prerequisite:
#2368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OrKoN OrKoN OrKoN approved these changes

@Lightning00Blade Lightning00Blade Awaiting requested review from Lightning00Blade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sadym-chromium @Lightning00Blade @OrKoN