fix: navigation with wait None
#2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadym-chromium
force-pushed
the
sadym/navigate-wait-none
branch
from
28c56cd to
0c395a1
Compare
OrKoN
approved these changes
Sep 2, 2024
sadym-chromium
pushed a commit
that referenced
this pull request
Sep 5, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.0](chromium-bidi-v0.6.5...chromium-bidi-v0.7.0) (2024-09-05) ### ⚠ BREAKING CHANGES * emit `browsingContext.contextDestroyed` once ([#2563](#2563)) ### Bug Fixes * always provide url in `browsingContext.navigationStarted` ([#2483](#2483)) ([318d621](318d621)) * emit `browsingContext.contextDestroyed` once ([#2563](#2563)) ([930d401](930d401)) * fail previous navigation on the next one ([#2569](#2569)) ([0cfd51a](0cfd51a)) * navigation with wait `None` ([#2557](#2557)) ([bf89379](bf89379)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not wait for the CDP command in case
BrowsingContext.navigatewithwait: None. ProvidependingNavigationIdto consistent navigation ID.