feat: implement Bluetooth Emulation BiDi mapping #2624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
alexnj
commented
Sep 18, 2024
alexnj
changed the title
OrKoN
approved these changes
Sep 19, 2024
OrKoN
changed the title
sadym-chromium
approved these changes
Sep 19, 2024
Lightning00Blade
changed the title
The CDDL generated portions are hardcoded and will be removed once generated fro spec.
|
@alexnj thanks for updating the types! I think they have been rolled now so this PR can be rebased and landed. |
sadym-chromium
pushed a commit
that referenced
this pull request
Oct 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.8.1](chromium-bidi-v0.8.0...chromium-bidi-v0.8.1) (2024-10-11) ### Features * implement Bluetooth Emulation BiDi mapping ([#2624](#2624)) ([48a233f](48a233f)) * support MPArch sessions ([#2662](#2662)) ([662485f](662485f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
| @@ -148,6 +148,16 @@ export class CommandProcessor extends EventEmitter<CommandProcessorEventsMap> { | |||
| return await this.#bluetoothProcessor.handleRequestDevicePrompt( | |||
| this.#parser.parseHandleRequestDevicePromptParams(command.params) | |||
| ); | |||
| case 'bluetooth.simulateAdapter': | |||
| return await this.#bluetoothProcessor.simulateAdapter(command.params); | |||
There was a problem hiding this comment.
FYI: the params should be parsed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the Bluetooth Emulation spec from WebBluetoothCG/web-bluetooth#630. Needs to wait until spec is landed before this can be merged.