Expose base.py as a public api. #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
two notes:
|
ricea
reviewed
Apr 22, 2021
Extract methods that can be used to implement Websocket over HTTP/2 The implementation of HTTP/2 handshake is quite similar to HTTP/1 with a few differences: - headers are lower case in HTTP/2 - not exactly the same headers must be validated - We don't handle Sec-WebSocket-Accept for HTTP/2 - the response is different So we can implement the handshake in a base class that will delegate some operations to the parent class. We make _base.py public by renaming it to base.py
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 20, 2021
Automatic update from web-platform-tests Squashed 'tools/third_party/pywebsocket3/' changes from 9db3d29db4..265579a969 265579a969 Expose base.py as a public api. (#28) cdb83e3152 Add missing r to regular expression (#27) git-subtree-dir: tools/third_party/pywebsocket3 git-subtree-split: 265579a969e1aec2a6457db7674a9e31fbb7d564 -- Merge commit '2a247ac52a4af9f82d50b2f96a43abe5c4629ed3' into HEAD -- update ws_h2_handshake.py to recent pywebsocket pywebsocket has been refactored to expose some utilities and base class as part of its public API. (see GoogleChromeLabs/pywebsocket3#28) By updating to the newest pywebsocket3 version, we can make ws_h2_handshake much simpler -- Merge commit 'ec57f8af52fe5e1074ec2de6a5d0d88c4cab257a' Closes web-platform-tests/wpt#28667. -- wpt-commits: 2a247ac52a4af9f82d50b2f96a43abe5c4629ed3, c3c4473d852203e78c4927408aae0b42f95b7385, ec57f8af52fe5e1074ec2de6a5d0d88c4cab257a, 24fa46db564eb4491e9f84edd3d1a07316cc14c6 wpt-pr: 28667
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract methods that can be used to implement Websocket over HTTP/2
The implementation of HTTP/2 handshake is quite similar to HTTP/1 with a
few differences:
So we can implement the handshake in a base class that will delegate
some operations to the parent class.
We make _base.py public by renaming it to base.py