Cherry Pick #1227 to Branch 3.0.x -> Fixing bug : Avoid registering subscriber class multiple times #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oogleCloudDataproc#1227) * Fixing bug to avoid registering subscriber class multiple times * Refactoring for Singleton pattern
|
/gcbrun |
arunkumarchacko
approved these changes
Jul 30, 2024
| public static synchronized GoogleCloudStorageEventSubscriber getInstance( | ||
| @Nonnull GhfsGlobalStorageStatistics storageStatistics) { | ||
| if (INSTANCE == null) { | ||
| logger.atFiner().log("Subscriber class invoked for first time"); |
There was a problem hiding this comment.
why not add it in the constructor
| public static synchronized GoogleCloudStorageEventSubscriber getInstance( | ||
| @Nonnull GhfsGlobalStorageStatistics storageStatistics) { | ||
| if (INSTANCE == null) { | ||
| logger.atFiner().log("Subscriber class invoked for first time"); |
There was a problem hiding this comment.
Rename this to "Created GoogleCloudStorageEventSubscriber"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.