Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assume that gcloud is in the path in providers.gcp.util.GetDefaultProject #1366

Merged
merged 1 commit into from
May 16, 2017
Merged

Don't assume that gcloud is in the path in providers.gcp.util.GetDefaultProject #1366

merged 1 commit into from
May 16, 2017

Conversation

tedsta
Copy link
Contributor

@tedsta tedsta commented May 16, 2017

Use FLAGS.gcloud_path

ehankland
ehankland approved these changes May 16, 2017
View reviewed changes
Copy link
Contributor

@ehankland ehankland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tedsta tedsta merged commit f45ec40 into master May 16, 2017
@bvliu bvliu deleted the gcp_default_project branch January 7, 2020 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehankland ehankland ehankland approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tedsta @ehankland @googlebot