Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for RAG prompt #511

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

andrewsykim
Copy link
Collaborator

No description provided.

@andrewsykim andrewsykim force-pushed the rag-e2e branch 9 times, most recently from 185f150 to 4782812 Compare April 1, 2024 03:43
@andrewsykim
Copy link
Collaborator Author

/gcbrun

@andrewsykim andrewsykim changed the title [WIP] Add tests for RAG prompt Add tests for RAG prompt Apr 1, 2024
@andrewsykim andrewsykim force-pushed the rag-e2e branch 2 times, most recently from e61ff0a to cf235e7 Compare April 1, 2024 04:29
@andrewsykim
Copy link
Collaborator Author

/gcbrun

1 similar comment
@andrewsykim
Copy link
Collaborator Author

/gcbrun

@andrewsykim
Copy link
Collaborator Author

andrewsykim commented Apr 1, 2024

Passing results from CI:

2024-04-01 05:23:18,178	SUCC cli.py:60 -- ------------------------------------------
2024-04-01 05:23:18,178	SUCC cli.py:61 -- Job 'raysubmit_AQ5UwhxiVXv7fph7' succeeded
2024-04-01 05:23:18,178	SUCC cli.py:62 -- ------------------------------------------
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
Handling connection for 8081
Testing prompt: List the cast of Squid Game
Reply:  The cast of Squid Game includes:

  * Lee Jung-jae
  * Park Hae-soo
  * Wi Ha-jun
  * Oh Young-soo
  * Jung Ho-yeon
  * Heo Sung-tae
  * Kim Joo-ryoung
  * Tripathi Anupam
  * You Seong-joo
  * Lee You-mi
Testing prompt: When was Squid Game released?
Reply: 
Squid Game was released on September 17, 2021.
Testing prompt: What is the rating of Squid Game?
Reply: 
The rating of Squid Game is TV-MA.
Testing prompt: List the cast of Avatar: The Last Airbender
Reply:  The cast of Avatar: The Last Airbender includes:

1. Zach Tyler as Aang
2. Mae Whitman as Katara
3. Jack De Sena as Sokka
4. Dee Bradley Baker as Toph, Sokka, and other characters
5. Dante Basco as Bolin
6. Jessie Flower as Suki
7. Mako Iwamatsu as Sokka (Japanese dub)
Testing prompt: When was Avatar: The Last Airbender added on Netflix?
Reply: 
Avatar: The Last Airbender was added to Netflix on May 15, 2020.
Testing prompt: What is the rating of Avatar: The Last Airbender?
Reply: 
The rating of Avatar: The Last Airbender is TV-Y7.

Unfortunately the adds an extra ~10m to the e2e tests to run the ray job, but I think the coverage is worth it.

@andrewsykim andrewsykim requested a review from imreddy13 April 1, 2024 11:39
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
@andrewsykim
Copy link
Collaborator Author

/gcbrun

@andrewsykim andrewsykim enabled auto-merge (squash) April 2, 2024 00:01
auto-merge was automatically disabled April 2, 2024 00:09

Base branch was modified

@andrewsykim andrewsykim merged commit 996de35 into GoogleCloudPlatform:main Apr 2, 2024
3 of 4 checks passed
ryanaoleary pushed a commit that referenced this pull request Apr 3, 2024
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
kfswain pushed a commit that referenced this pull request Apr 15, 2024
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants