-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for RAG prompt #511
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsykim
commented
Mar 31, 2024
andrewsykim
force-pushed
the
rag-e2e
branch
9 times, most recently
from
April 1, 2024 03:43
185f150
to
4782812
Compare
/gcbrun |
andrewsykim
force-pushed
the
rag-e2e
branch
2 times, most recently
from
April 1, 2024 04:29
e61ff0a
to
cf235e7
Compare
/gcbrun |
1 similar comment
/gcbrun |
Passing results from CI:
Unfortunately the adds an extra ~10m to the e2e tests to run the ray job, but I think the coverage is worth it. |
andrewsykim
commented
Apr 1, 2024
andrewsykim
commented
Apr 1, 2024
andrewsykim
commented
Apr 1, 2024
Merged
imreddy13
reviewed
Apr 1, 2024
imreddy13
approved these changes
Apr 1, 2024
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
/gcbrun |
auto-merge was automatically disabled
April 2, 2024 00:09
Base branch was modified
ryanaoleary
pushed a commit
that referenced
this pull request
Apr 3, 2024
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
kfswain
pushed a commit
that referenced
this pull request
Apr 15, 2024
Signed-off-by: Andrew Sy Kim <andrewsy@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.