Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webhook cert-manager install to work with GKE autopilot clusters #585

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

ryanaoleary
Copy link
Collaborator

This PR changes the make install-cert-manager command to one that works for both GKE standard and autopilot clusters. The previous kubectl apply command to install cert-manager is incompatible with GKE autopilot since the default global.leaderElection.namespace is a managed namespace on autopilot.

This PR was tested by installing cert-manager using the helm commands on both standard and autopilot clusters and verifying that the webhook was successfully issued a certificate.

@ryanaoleary ryanaoleary self-assigned this Apr 12, 2024
@ryanaoleary ryanaoleary requested a review from richardsliu April 12, 2024 23:20
@ryanaoleary
Copy link
Collaborator Author

/gcbrun

@ryanaoleary ryanaoleary enabled auto-merge (squash) April 15, 2024 17:57
@ryanaoleary ryanaoleary merged commit cb4efad into main Apr 15, 2024
8 checks passed
@ryanaoleary ryanaoleary deleted the cert-manager-update branch April 15, 2024 20:23
alpha-amundson pushed a commit that referenced this pull request May 3, 2024
…rs (#585)

* Change install-cert-manager to work with autopilot clusters

* Add cert-manager install commands to TPU_GUIDE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants