Set the default GKE cluster type for jupyterhub to GKE Autopilot. #599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cluster_name = "ml-cluster" | ||
| cluster_location = "us-central1" | ||
| cluster_membership_id = "" # required for private cluster, defaults to `cluster_name` | ||
| autopilot_cluster = true |
There was a problem hiding this comment.
Maybe move this up to be with create_cluster so the variables are together since they are related.
There was a problem hiding this comment.
all of the flags in this section are related to the create cluster (cluster name, location, type, fleet membership). I've moved the flag up one line, but since I expect that it's more likely to change the cluster name or location than the type, I'd prefer to leave it below those two variables.
There was a problem hiding this comment.
Restructured a bit more so that the terraform lint check would pass.
roberthbailey
force-pushed
the
jupyter-autopilot
branch
5 times, most recently
from
0c118b1 to
ba46585
Compare
Also add instructions to use a standard cluster if preferred.
roberthbailey
force-pushed
the
jupyter-autopilot
branch
from
ba46585 to
1e8b7ed
Compare
|
/gcbrun |
gongmax
pushed a commit
that referenced
this pull request
Apr 26, 2024
Also add instructions to use a standard cluster if preferred.
roberthbailey
added a commit
to roberthbailey/ai-on-gke
that referenced
this pull request
Apr 29, 2024
…ogleCloudPlatform#599) Also add instructions to use a standard cluster if preferred.
roberthbailey
added a commit
that referenced
this pull request
Apr 29, 2024
Also add instructions to use a standard cluster if preferred.
alpha-amundson
pushed a commit
that referenced
this pull request
May 3, 2024
Also add instructions to use a standard cluster if preferred.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add instructions to use a standard cluster if preferred.