fix hardcoded request type #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annapendleton
requested review from
kfswain,
achandrasekar and
hubatish
and removed request for
achandrasekar and
ahg-g
hubatish
reviewed
May 14, 2024
benchmarks/benchmark/tools/locust-load-inference/sample-terraform.tfvars
Show resolved
Hide resolved
hubatish
reviewed
May 14, 2024
benchmarks/benchmark/tools/locust-load-inference/locust-docker/locust-tasks/run.sh
Show resolved
Hide resolved
kfswain
reviewed
May 14, 2024
benchmarks/benchmark/tools/locust-load-inference/sample-terraform.tfvars
Show resolved
Hide resolved
kfswain
approved these changes
May 14, 2024
|
tested end to end for http (manual testing required until we have presubmits). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for hardcoded request type in locust - plumbs variable through and adds extra logging in run.sh.
Currently under e2e validation