Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TPU Provisioner] Add admission label selectors and e2e test script #702

Merged
merged 2 commits into from
Jun 24, 2024
Merged

[TPU Provisioner] Add admission label selectors and e2e test script #702

merged 2 commits into from
Jun 24, 2024

Conversation

nstogner
Copy link
Collaborator

  • Avoid mutation when provisioning is disabled
  • Avoid mutation for Jobs not managed by a JobSet
  • Add e2e test script and cases

@nstogner nstogner requested a review from danielvegamyhre June 13, 2024 15:28
danielvegamyhre
danielvegamyhre approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@danielvegamyhre danielvegamyhre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this.

@danielvegamyhre danielvegamyhre merged commit fd738a6 into GoogleCloudPlatform:main Jun 24, 2024
5 checks passed
german-grandas pushed a commit to german-grandas/ai-on-gke that referenced this pull request Jun 28, 2024
@nstogner @german-grandas
[TPU Provisioner] Add admission label selectors and e2e test script (G…
2047d4d 
…oogleCloudPlatform#702)

* Add admission label selectors and e2e test script

* Edit log msgs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielvegamyhre danielvegamyhre danielvegamyhre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nstogner @danielvegamyhre