Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use ray addon when creating GKE clusters #781

Merged
merged 2 commits into from
Aug 31, 2024
Merged

fix: use ray addon when creating GKE clusters #781

merged 2 commits into from
Aug 31, 2024

Conversation

genlu2011
Copy link
Collaborator

@genlu2011 genlu2011 commented Aug 21, 2024 •
edited
Loading

This PR uses ray addon to install kuberay operator and removes the overhead to manage logging and monitoring.

  1. Upgrade the gke submodule version to 32.0.1 to use ray-addon to create GKE cluster.
  2. Upgrade the k8s version to 1.30.3 to use ray addon.
  3. Removed the configuration related to fluent-bit image in Ray cluster module, since it is managed by ray addon now.
  4. Removed the configuration to setup monitoring in kuberay-monitoring module.
  5. Removed installing kuberay-operator, kuberay-logging module in rag/ray application.

@genlu2011 genlu2011 requested a review from imreddy13 August 21, 2024 23:44
@genlu2011 genlu2011 force-pushed the genlu/feat/use_ray_addon branch from a08e498 to d08cf46 Compare August 21, 2024 23:46
@imreddy13 imreddy13 requested a review from andrewsykim August 23, 2024 18:43
andrewsykim
andrewsykim reviewed Aug 23, 2024
View reviewed changes
applications/ray/main.tf Show resolved Hide resolved
applications/ray/main.tf Show resolved Hide resolved
applications/ray/main.tf Show resolved Hide resolved
@genlu2011
Copy link
Collaborator Author

/gcbrun

@genlu2011
fix: use ray addon when creating GKE clusters
d15b816 
Change-Id: Iac49ae3e2d57701754a50cbfc10b9bba70829f41
@genlu2011 genlu2011 force-pushed the genlu/feat/use_ray_addon branch 2 times, most recently from ad373c1 to 351e9c6 Compare August 29, 2024 19:16
@genlu2011
Copy link
Collaborator Author

/gcbrun

@genlu2011 genlu2011 force-pushed the genlu/feat/use_ray_addon branch from 351e9c6 to 11dfd75 Compare August 29, 2024 23:19
@genlu2011
Copy link
Collaborator Author

/gcbrun

@genlu2011 genlu2011 mentioned this pull request Aug 29, 2024
Closed
@genlu2011 genlu2011 force-pushed the genlu/feat/use_ray_addon branch from 11dfd75 to 184eccd Compare August 29, 2024 23:27
@genlu2011
Copy link
Collaborator Author

/gcbrun

@genlu2011 genlu2011 force-pushed the genlu/feat/use_ray_addon branch from 184eccd to c401bd3 Compare August 30, 2024 19:41
@genlu2011
Copy link
Collaborator Author

/gcbrun

@genlu2011 genlu2011 force-pushed the genlu/feat/use_ray_addon branch from c401bd3 to 6efbd64 Compare August 30, 2024 21:08
@genlu2011
Copy link
Collaborator Author

/gcbrun

@genlu2011 genlu2011 force-pushed the genlu/feat/use_ray_addon branch 2 times, most recently from b981bbc to 4492a42 Compare August 30, 2024 21:47
@genlu2011
Copy link
Collaborator Author

/gcbrun

@genlu2011 genlu2011 force-pushed the genlu/feat/use_ray_addon branch from 4492a42 to 48c3ebd Compare August 31, 2024 03:35
@genlu2011
Copy link
Collaborator Author

/gcbrun

@genlu2011
delete kuberay-logging and kuberay-operator module
6e3930c 
Change-Id: I2b8eda653bcf4b1d1cd402111e7bd79d18eaf1ac
@genlu2011 genlu2011 force-pushed the genlu/feat/use_ray_addon branch from 48c3ebd to 6e3930c Compare August 31, 2024 03:37
@genlu2011
Copy link
Collaborator Author

/gcbrun

@genlu2011 genlu2011 enabled auto-merge (squash) August 31, 2024 04:25
@genlu2011 genlu2011 merged commit 1d8ccc3 into main Aug 31, 2024
11 checks passed
@german-grandas german-grandas mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsykim andrewsykim andrewsykim left review comments

@imreddy13 imreddy13 imreddy13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@genlu2011 @andrewsykim @imreddy13