Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the benchmark time configurable and set default to 2 minutes #833

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

achandrasekar
Copy link
Collaborator

This change makes the benchmark time configurable so it makes it easy to tweak it and identify when we reach steady state. This change also increases the default time from 30 seconds to 2 minutes based on experimental data.

This change makes the benchmark time configurable so it makes it easy to
tweak it and identify when we reach steady state. This change also
increases the default time from 30 seconds to 2 minutes based on
experimental data.
Copy link
Collaborator

@Bslabe123 Bslabe123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achandrasekar achandrasekar merged commit 6860cf5 into GoogleCloudPlatform:main Sep 25, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants