Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model load with gcs fuse benchmarking tool #863

Merged
merged 10 commits into from
Oct 29, 2024
Merged

Model load with gcs fuse benchmarking tool #863

merged 10 commits into from
Oct 29, 2024

Conversation

coolkp
Copy link
Collaborator

@coolkp coolkp commented Oct 29, 2024

Benchmarking tool for benchmarking data loading with gcsfuse

@coolkp coolkp marked this pull request as ready for review October 29, 2024 15:20
coolkp added 3 commits October 29, 2024 17:02
@coolkp
Add more information to Readme
bee5682 
Signed-off-by: Kunjan Patel <kunjanp@google.com>
@coolkp
Add more information to Readme
4131859 
Signed-off-by: Kunjan Patel <kunjanp@google.com>
@coolkp
Yaml format
e6e55a0 
Signed-off-by: Kunjan Patel <kunjanp@google.com>
coolkp added 3 commits October 29, 2024 17:30
@coolkp
format requirements.txt
345a7c2 
Signed-off-by: Kunjan Patel <kunjanp@google.com>
@coolkp
Add check for pod node placement before begining profiling
ec7230b 
Signed-off-by: Kunjan Patel <kunjanp@google.com>
@coolkp
Add check for pod node placement before begining profiling
b372fc0 
Signed-off-by: Kunjan Patel <kunjanp@google.com>
genlu2011
genlu2011 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@genlu2011 genlu2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

achandrasekar
achandrasekar requested changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@achandrasekar achandrasekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@coolkp can we add this under our benchmarks directory where we have other benchmarks like dlio, lpg and locust? It also gives us the ability to use the terraform modules for cluster provisioning if needed.

@coolkp
Move under benchmarks/benchmark/tools
b45e130 
Signed-off-by: Kunjan Patel <kunjanp@google.com>
@coolkp coolkp requested a review from achandrasekar October 29, 2024 18:30
coolkp
coolkp commented Oct 29, 2024
View reviewed changes
Copy link
Collaborator Author

@coolkp coolkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

achandrasekar
achandrasekar approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@achandrasekar achandrasekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the change!

@achandrasekar achandrasekar merged commit 9e89326 into GoogleCloudPlatform:main Oct 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@genlu2011 genlu2011 genlu2011 approved these changes

@achandrasekar achandrasekar achandrasekar approved these changes

@ahg-g ahg-g Awaiting requested review from ahg-g ahg-g is a code owner

@annapendleton annapendleton Awaiting requested review from annapendleton annapendleton is a code owner

@Bslabe123 Bslabe123 Awaiting requested review from Bslabe123 Bslabe123 is a code owner

@jjk-g jjk-g Awaiting requested review from jjk-g jjk-g is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coolkp @achandrasekar @genlu2011