Use the tpu_network_optimizer image instead of a raw bash script. #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The container image contains the script, but makes future updates (if necessary) more straightforward by just pulling a new image rather than updating the sript inside the daemonset. The contents of the image also allow us to mount only /sys and /proc, instead of mounting / entirely.
|
Where is this image built from? Tagging @NoahJohnson1 and @thebinaryone1 to review as they have previously worked on this. |
|
Not sure if I'm misunderstanding your question, but the image is built internally as a distroless kubernetes container image. |
|
Yeah this is built internally and has functionally identical script contents. For newer versions of GKE this image and its optimization script are invoked automatically on v6e, so the intent is to update this older manual DS to be consistent with what newer GKE versions provide. |
|
(LGTM, for the record) |
thebinaryone1
approved these changes
Nov 14, 2024
thebinaryone1
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The container image contains the script, but makes future updates (if necessary) more straightforward by just pulling a new image rather than updating the sript inside the daemonset. The contents of the image also allow us to mount only /sys and /proc, instead of mounting / entirely.