refactor: update AlloyDBClient and ConnectionInfo classes #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwotherspoon
commented
Jun 24, 2024
| @@ -236,6 +238,55 @@ async def _get_client_certificate( | |||
| ).decode("UTF-8") | |||
| return (server_cert, [client_cert, intermediate_cert, root_cert]) | |||
|
|
|||
| async def get_connection_info( | |||
There was a problem hiding this comment.
will have a follow-up PR to clean up the FakeAlloyDBClient mock to remove this copy/paste code.
enocom
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor of
AlloyDBClientandConnectionInfoclasses.Added the
get_connection_infomethod to the AlloyDBClient.This method does an immediate refresh and calls the AlloyDB APIs
to get a fresh
ConnectionInfo. This allows better encapsulation.Refactored
ConnectionInfoto a dataclass and added two new methods;create_ssl_contextandget_preferred_ip. Moved all SSL/TLS configurationwithin
create_ssl_context. This way ConnectionInfo() prepares all the inforequired to connect and then
create_ssl_contextwill use the info to establishthe SSL/TLS connection when called from
Connector.connectat the time ofconnection.
Port of GoogleCloudPlatform/cloud-sql-python-connector#1079 and GoogleCloudPlatform/cloud-sql-python-connector#1090
Related to #298