Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Python 3.13 #383

Merged
merged 5 commits into from
Nov 6, 2024
Merged

feat: add support for Python 3.13 #383

merged 5 commits into from
Nov 6, 2024

Conversation

rhatgadkar-goog
Copy link
Collaborator

No description provided.

@rhatgadkar-goog rhatgadkar-goog linked an issue Oct 24, 2024 that may be closed by this pull request
@jackwotherspoon
Copy link
Collaborator

@rhatgadkar-goog PR looks great, to get this PR green you will need a couple things:

  • this PR will be blocked until chore(deps): update python-nonmajor #375 is merged which updates asyncpg to 0.30.0 for tests
  • will need to update required checks in branch protection settings to be 3.9 and 3.13 and no longer 3.8 and 3.12

Nice stuff here! 👏

@rhatgadkar-goog
Copy link
Collaborator Author

rhatgadkar-goog commented Oct 25, 2024

Thanks Jack! How do I update the branch protection settings? I checked out this page, but wasn't able to find the Settings menu of the repository.

@enocom
Copy link
Member

enocom commented Oct 25, 2024

You should now have permission to see that page. 😉

@rhatgadkar-goog rhatgadkar-goog changed the title Add support for Python 3.13 and drop support for Python 3.8 feat: add support for Python 3.13 Oct 30, 2024
@rhatgadkar-goog
Copy link
Collaborator Author

We are blocked from supporting Python 3.13, because we can't install psycopg2 package on it.

Python 3.13 requires psycopg 2.9.10: https://www.psycopg.org/docs/news.html#what-s-new-in-psycopg-2-9-10. But its support for it is still in progress: psycopg/psycopg2#1736.

@enocom So should we not install the psycopg package for now?: #388

.github/workflows/tests.yaml Outdated Show resolved Hide resolved
…pg from requirements-test.txt, revert back to macos-latest
@rhatgadkar-goog rhatgadkar-goog marked this pull request as ready for review November 6, 2024 18:55
@rhatgadkar-goog rhatgadkar-goog requested a review from a team as a code owner November 6, 2024 18:55
Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to update the branch protection settings.

@rhatgadkar-goog rhatgadkar-goog merged commit 22ef77c into main Nov 6, 2024
15 checks passed
@rhatgadkar-goog rhatgadkar-goog deleted the python-3.13 branch November 6, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.13
4 participants