Set resource #138
Merged
Set resource #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add OpenTelemetry Collector monitoring sidecar (GoogleCloudPlatform#134)
Renames the opencensus-monitoring directory and adds comments to it. …
This allows setting the monitored resource using a processor. Also updates metrics_receiver to match the new receiver interface.
This prevents conflicts with a resource set using a processor.
In an earlier commit a typo in the error metric name was fixed so that it matches the monitoring configs. This adjusts the tests to match.
Could you add a link to your changs? |
|
The changes I made to contrib.go.opencensus.io/exporter/stackdriver are at census-ecosystem/opencensus-go-exporter-stackdriver#253. |
yanweiguo
reviewed
Feb 26, 2020
opentelemetry_collector/run.sh
Outdated
| @@ -1,21 +1,36 @@ | |||
| #!/bin/bash | |||
|
|
|||
| BUILD_DATE_FILE=/config/build_date.txt | |||
There was a problem hiding this comment.
What format is the build date in this file? I wonder whether we can use an env var as well.
yanweiguo
approved these changes
Feb 26, 2020
imccarten1
added a commit
to imccarten1/appengine-sidecars-docker
that referenced
this pull request
Feb 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the sidecar code to write to the correct metric and set the monitored resource as gae_instance.
Note: the replace directive in go.mod for contrib.go.opencensus.io/exporter/stackdriver will be removed once there is a new release for the repository. The changes I made are checked into the main repository but not yet in a release.