Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update LTS 7 versions. #2368

Merged
merged 11 commits into from
Aug 2, 2024
Merged

deps: update LTS 7 versions. #2368

merged 11 commits into from
Aug 2, 2024

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Apr 3, 2024

No description provided.

@zhumin8
Copy link
Contributor Author

zhumin8 commented Apr 3, 2024 •
edited
Loading

error message:

Error:  Failures: 
Error:    BomContentTest.testLtsBom:62->checkBom:81->assertUniqueClasses:154 Failing test due to duplicate classes found on classpath:
Duplicate class META-INF.versions.9.module-info found in classpath. Found in artifacts com.google.errorprone:error_prone_annotations:2.26.1 and com.google.j2objc:j2objc-annotations:3.0.0.
Duplicate class META-INF.versions.9.module-info found in classpath. Found in artifacts com.google.errorprone:error_prone_annotations:2.26.1 and com.google.auto.value:auto-value:1.10.4.

META-INF.versions.9.module-info contains java module infor for jdk>9. Should this be excluded from check?
cc. @suztomo

@zhumin8 zhumin8 mentioned this pull request Apr 4, 2024
Merged
@zhumin8 zhumin8 added the kokoro:run force run kokoro label Apr 11, 2024
@cloud-tools-for-java-team cloud-tools-for-java-team removed the kokoro:run force run kokoro label Apr 11, 2024
@zhumin8 zhumin8 requested a review from suztomo July 31, 2024 14:56
suztomo
suztomo reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kmaydeo Would you review this?

@zhumin8 zhumin8 merged commit 25ffc31 into master Aug 2, 2024
5 checks passed
@zhumin8 zhumin8 deleted the lts-7.0 branch August 2, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo left review comments

@kmaydeo kmaydeo kmaydeo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhumin8 @suztomo @kmaydeo @cloud-tools-for-java-team