This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Fix sandboxctl destroy timeout #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 9, 2021 13:24
For commands that waiting for user input
Ayelet41
requested review from
daniel-sanche,
0xSage and
simonz130
as code owners
google-cla
bot
added
the
cla: yes
0xSage
reviewed
Jun 10, 2021
0xSage
reviewed
Jun 10, 2021
simonz130
approved these changes
Jun 10, 2021
daniel-sanche
suggested changes
Jun 15, 2021
added 2 commits
June 16, 2021 11:17
Use describe instead of list to reduce waiting time.
| ) | ||
| output, error = process.communicate() | ||
| return output, error | ||
| process = subprocess.run(command.split()) |
There was a problem hiding this comment.
nit: It might be useful to return some data from the completed process like before. If not, then you should get rid of the unused process variable
daniel-sanche
approved these changes
Jun 17, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added run_command_interactive to solve sandboxctl destroy hang without affecting other call to run_command function.