This repository has been archived by the owner on Nov 2, 2024. It is now read-only.
feat: upgrade Istio 1.7.1 to ASM #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathieu-benoit
approved these changes
Jun 13, 2022
There was a problem hiding this comment.
I did my review, this LGTM, great job!
Disclaimer: I haven't tested this PR myself.
For a future PR, here are what could be done in addition/on top of that:
- Use the ASM TF Module to remove the need of the
asmclibin - The Ingress Gateway, based on the above point will have its own dedicated installation manifests
- Managed Data plane seems to be a good candidate too for the Cloud Ops sandbox in order to simplify the upgrade of the sidecar proxies by Google
- Note: the
frontend-externalServicecould also be removed from the manifests since the Ingress Gateway is the only Public IP needed.
@daniel-sanche, do you need to update the description of this PR to better reflect where you landed? I see some notes about WI but don't see anymore these changes as an example.
|
@mathieu-benoit Thanks for the feedback! I added your comments to the issue around terraform refactoring for next quarter. And yeah, it seems the description is a bit out of date as I ended up moving some parts into other PRs, but I'll make sure to fix it before merging |
Closed
This was referenced Jun 15, 2022
Closed
Merged
daniel-sanche
added a commit
that referenced
this pull request
Jun 16, 2022
This was referenced Sep 19, 2022
Closed
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users had reported that monitoring data hasn't been showing up in Cloud Monitoring. This seems to be due to incompatibility with the out-dated Istio version being used by this project. To resolve this, I updated to use the latest version of ASM, which should be more useful for demos