Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

chore: test adjustments #946

Merged
merged 4 commits into from
Jun 16, 2022
Merged

chore: test adjustments #946

merged 4 commits into from
Jun 16, 2022

Conversation

daniel-sanche
Copy link
Member

  • We recently added sandboxctl test to run tests against a live sandbox environment, but it wasn't working for the ratingservice tests. This fixes that
  • added a dependency to the make-release release pipeline, so it will run steps in sequence instead of parallel (add dependency on release pipeline jobs #943)
  • removed quotes from workflow custom image trigger, since the trigger wasn't firing and removing quotes seems to be better in line with the spec

@github-actions
Copy link

Open in Cloud Shell
You can also use the Stage Website Action if there were updates to the website.

Note: Open in Cloud Shell may not work properly if this PR contains changes to the custom Cloud Shell image

Copy link
Collaborator

@minherz minherz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@daniel-sanche daniel-sanche merged commit 793c6c2 into develop Jun 16, 2022
@daniel-sanche daniel-sanche deleted the test-fixes branch June 16, 2022 15:51
@github-actions github-actions bot mentioned this pull request Jun 16, 2022
daniel-sanche added a commit that referenced this pull request Jun 16, 2022
This was referenced Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants