refactor: move TLS config creation to ConnectionInfo #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enocom
force-pushed
the
connection-info-2
branch
from
db5defe
to
3f56e8c
Compare
enocom
force-pushed
the
connection-info-2
branch
from
3f56e8c
to
883ae8c
Compare
enocom
force-pushed
the
connection-info-2
branch
from
883ae8c
to
463628d
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
enocom
force-pushed
the
connection-info-2
branch
from
463628d
to
873f799
Compare
This refactor moves all TLS configuration into the connection info type and leaves room for altering the configuration based on the request connection path, rather than hiding the configuration deep within the code that retrieves the ephemeral certificate.
enocom
force-pushed
the
connection-info-2
branch
from
873f799
to
3185637
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor moves all TLS configuration into the connection info type and leaves room for altering the configuration based on the request connection path, rather than hiding the configuration deep within the code that retrieves the ephemeral certificate.