Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Cloud Monitoring and Cloud Trace #1212

Merged
merged 7 commits into from
Jun 13, 2022
Merged

Conversation

enocom
Copy link
Member

@enocom enocom commented Jun 1, 2022

No description provided.

Users may now enable metrics and traces from the Go connector by
supplying a "telemetry-project" and project ID. Optionally, users may
also set a metrics prefix.
@enocom enocom requested a review from a team June 1, 2022 22:07
@kurtisvg kurtisvg changed the title feat: add flags to enable Cloud Monitoring and Trace feat: add support for Cloud Monitoring and Cloud Trace Jun 6, 2022
cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
This commit separates metrics and tracing, allowing each to be enabled
on their own. In addition, it adds support for configuring the default
probabilistic sampling rate and otherwise uses the default where
1/10,000 calls will be traced.
@enocom enocom requested a review from kurtisvg June 7, 2022 04:37
cmd/root.go Outdated Show resolved Hide resolved
cmd/root.go Outdated Show resolved Hide resolved
enocom added 2 commits June 13, 2022 11:40
- Remove short flags for telemetry
- Simplify exporter configuration
- Add test and fix for bad boolean logic
@enocom enocom requested a review from kurtisvg June 13, 2022 18:03
cmd/root.go Outdated Show resolved Hide resolved
@enocom enocom requested a review from kurtisvg June 13, 2022 19:44
@enocom enocom merged commit 30db50b into v2 Jun 13, 2022
@enocom enocom deleted the enable-telemetry branch June 13, 2022 20:05
enocom added a commit that referenced this pull request Jun 17, 2022
Users may now enable metrics and traces from the Go connector by
supplying a "telemetry-project" and project ID. Optionally, users may
also set a metrics prefix.

Separately, this commit separates metrics and tracing, allowing each to
be enabled on their own. In addition, it adds support for configuring the default
probabilistic sampling rate and otherwise uses the default where
1/10,000 calls will be traced.
enocom added a commit to GoogleCloudPlatform/alloydb-auth-proxy that referenced this pull request Jul 8, 2022
enocom added a commit to GoogleCloudPlatform/alloydb-auth-proxy that referenced this pull request Jul 8, 2022
enocom added a commit that referenced this pull request Jul 12, 2022
Users may now enable metrics and traces from the Go connector by
supplying a "telemetry-project" and project ID. Optionally, users may
also set a metrics prefix.

Separately, this commit separates metrics and tracing, allowing each to
be enabled on their own. In addition, it adds support for configuring the default
probabilistic sampling rate and otherwise uses the default where
1/10,000 calls will be traced.
enocom added a commit that referenced this pull request Jul 27, 2022
Users may now enable metrics and traces from the Go connector by
supplying a "telemetry-project" and project ID. Optionally, users may
also set a metrics prefix.

Separately, this commit separates metrics and tracing, allowing each to
be enabled on their own. In addition, it adds support for configuring the default
probabilistic sampling rate and otherwise uses the default where
1/10,000 calls will be traced.
enocom added a commit that referenced this pull request Aug 23, 2022
Users may now enable metrics and traces from the Go connector by
supplying a "telemetry-project" and project ID. Optionally, users may
also set a metrics prefix.

Separately, this commit separates metrics and tracing, allowing each to
be enabled on their own. In addition, it adds support for configuring the default
probabilistic sampling rate and otherwise uses the default where
1/10,000 calls will be traced.
enocom added a commit that referenced this pull request Aug 29, 2022
Users may now enable metrics and traces from the Go connector by
supplying a "telemetry-project" and project ID. Optionally, users may
also set a metrics prefix.

Separately, this commit separates metrics and tracing, allowing each to
be enabled on their own. In addition, it adds support for configuring the default
probabilistic sampling rate and otherwise uses the default where
1/10,000 calls will be traced.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants