feat: improve key for connector cache #1172
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve dictionary key for
connector._cache
.Previously, key for dictionary was the Cloud SQL instance's connection name
(
instance_connection_string
).However, there is differing logic for connecting with
enable_iam_auth=True
vs without. This resulted in having to throw an error and having a customer
create two separate connector objects if they want to connect to a single
instance with both auto IAM AuthN and regular user/password.
This PR makes the dictionary key a tuple consisting of
(instance_connection_string, enable_iam_auth)
.This allows a single connector to cache two separate entries for the same Cloud SQL instance,
one for
enable_iam_auth=True
and one forenable_iam_auth=False
.Closes #1013