Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an integration test for chrome-remote-desktop module #1027

Conversation

nick-stroud
Copy link
Collaborator

This change adds a simple integration test to confirm the installation and startup of the chrome-remote-desktop module.

This test will help monitor for issues such as the one raised in #1019, and will prevent breakage to the CRD startup scripts as changes are made.

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this. I added two comments.

@cboneti cboneti assigned nick-stroud and unassigned cboneti Mar 15, 2023
@nick-stroud nick-stroud force-pushed the remote-desktop-integration-test branch from 457ead4 to 7b34c6a Compare March 15, 2023 23:00
@nick-stroud nick-stroud assigned cboneti and unassigned nick-stroud Mar 15, 2023
@nick-stroud nick-stroud merged commit 5ba1446 into GoogleCloudPlatform:develop Mar 15, 2023
@cboneti cboneti assigned nick-stroud and unassigned cboneti Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants