Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix labels dtype in DDN-EXAScaler #1039

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Fix labels dtype in DDN-EXAScaler #1039

merged 1 commit into from
Mar 17, 2023

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Mar 16, 2023

Miss out from PR #1038

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@mr0re1 mr0re1 requested a review from tpdownes March 16, 2023 22:57
tpdownes
tpdownes approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpdownes tpdownes assigned mr0re1 and unassigned tpdownes Mar 17, 2023
@mr0re1 mr0re1 merged commit 757cb3b into GoogleCloudPlatform:develop Mar 17, 2023
@mr0re1 mr0re1 deleted the fix_labels branch August 21, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdownes tpdownes tpdownes approved these changes

Assignees

@mr0re1 mr0re1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr0re1 @tpdownes