Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring of code around expressions #1042

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Mar 17, 2023

  • Remove unused ResolveGlobalVariables;
  • Compile regexes once and remove exessive error handling;

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

- Remove unused `ResolveGlobalVariables`;
- Compile regexes once and remove exessive error handling;
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The way I understand this change is that if (somehow) any of the regular expressions fail to compile, it will manifest as an immediate panic upon invoking ghpc with any set of arguments.

if I misunderstand, please let me know before merging.

@tpdownes tpdownes assigned mr0re1 and unassigned tpdownes Mar 20, 2023
@mr0re1
Copy link
Collaborator Author

mr0re1 commented Mar 20, 2023

if any of the regular expressions fail to compile, it will manifest as an immediate panic upon invoking ghpc

Correct. https://go.dev/play/p/3t2TrJmyJNL

@mr0re1 mr0re1 merged commit 2ef34ab into GoogleCloudPlatform:develop Mar 20, 2023
@mr0re1 mr0re1 deleted the explore_expressions branch March 20, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants