Refactoring to support edge-tracking in graph #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Re-implement `modReference` and `varReference` structs to implement a new interface named `reference` - Adopt the `reference` interface in the `ModConnection` struct that tracks edges within the blueprint graph
nick-stroud
reviewed
Mar 23, 2023
nick-stroud
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modReferenceandvarReferencestructs to implement a new interface namedreferencereferenceinterface in theModConnectionstruct that tracks edges within the blueprint graphThese changes represent some design elements considered during implementation of references but weren't quite yet necessary to glue together.
Coverage in expand.go drops slightly due to the inclusion of new getter functions that seem too simple to merit unit testing. There appears to be no way to mark code as unreachable/not-meriting-testing for coverage percentages. This is area of active discussion in various Go channels.
Submission Checklist
pre-commit install)make tests)