Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve version constraint on batch-job-template module #1084

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Improve version constraint on batch-job-template module #1084

merged 1 commit into from
Mar 24, 2023

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Mar 24, 2023 •
edited
Loading

This PR does not alter the version of the module that would be installed today but prevents future breaking upgrades.

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@nick-stroud nick-stroud assigned tpdownes and unassigned nick-stroud Mar 24, 2023
@tpdownes tpdownes assigned nick-stroud and unassigned tpdownes Mar 24, 2023
@nick-stroud nick-stroud assigned tpdownes and unassigned nick-stroud Mar 24, 2023
@tpdownes tpdownes merged commit a8adb9f into GoogleCloudPlatform:develop Mar 24, 2023
@tpdownes tpdownes deleted the better_contraint branch March 24, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-stroud nick-stroud nick-stroud approved these changes

Assignees

@tpdownes tpdownes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpdownes @nick-stroud