Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Installation, Basic Usage, and Development documentation #109

Merged
merged 3 commits into from
Feb 11, 2022

Conversation

nick-stroud
Copy link
Collaborator

@nick-stroud nick-stroud commented Feb 10, 2022

In future submissions I plan to add a section outlining quota requirements, and first time GCP setup which can be referenced from these instructions once authored.

Submission Checklist:

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change? - NA
  • Is unit test coverage still above 80%? - NA
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 164: make ghpc-dev no longer exists.
it seems you could remove 95-99.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@nick-stroud nick-stroud changed the title Update Installation and Basic Usage instructions to use Cloud Shell Update Installation, Basic Usage, and Development documentation Feb 11, 2022
@nick-stroud nick-stroud force-pushed the cloud_shell_docs branch 2 times, most recently from af4f4aa to 8662a3d Compare February 11, 2022 16:59
@cboneti cboneti removed their request for review February 11, 2022 18:57
Copy link
Contributor

@heyealex heyealex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple typos, let me know when they're resolved and I'll approve

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
This readme will replace the quickstart section of the user guide.
@heyealex heyealex merged commit 8d09177 into GoogleCloudPlatform:develop Feb 11, 2022
@nick-stroud nick-stroud deleted the cloud_shell_docs branch April 28, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants