-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Installation, Basic Usage, and Development documentation #109
Merged
heyealex
merged 3 commits into
GoogleCloudPlatform:develop
from
nick-stroud:cloud_shell_docs
Feb 11, 2022
Merged
Update Installation, Basic Usage, and Development documentation #109
heyealex
merged 3 commits into
GoogleCloudPlatform:develop
from
nick-stroud:cloud_shell_docs
Feb 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cboneti
reviewed
Feb 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 164: make ghpc-dev no longer exists.
it seems you could remove 95-99.
heyealex
reviewed
Feb 11, 2022
nick-stroud
force-pushed
the
cloud_shell_docs
branch
from
February 11, 2022 03:59
5a6905a
to
301c539
Compare
nick-stroud
commented
Feb 11, 2022
nick-stroud
changed the title
Update Installation and Basic Usage instructions to use Cloud Shell
Update Installation, Basic Usage, and Development documentation
Feb 11, 2022
nick-stroud
force-pushed
the
cloud_shell_docs
branch
2 times, most recently
from
February 11, 2022 16:59
af4f4aa
to
8662a3d
Compare
heyealex
reviewed
Feb 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple typos, let me know when they're resolved and I'll approve
This readme will replace the quickstart section of the user guide.
nick-stroud
force-pushed
the
cloud_shell_docs
branch
from
February 11, 2022 22:34
8662a3d
to
fd02d5a
Compare
heyealex
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In future submissions I plan to add a section outlining quota requirements, and first time GCP setup which can be referenced from these instructions once authored.
Submission Checklist:
pre-commit install
make tests
change? - NA
guides?