Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several minor fixes #1095

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Several minor fixes #1095

merged 3 commits into from
Mar 28, 2023

Conversation

tpdownes
Copy link
Member

This PR combines several minor fixes:

  • fix varReference implementation of reference interface
  • fix fromModuleID values in varReference, modReference and catch in unit testing
  • one-line a func where it improves readability

Submission Checklist

  • Have you installed and run this change against pre-commit? (pre-commit install)
  • Are all tests passing? (make tests)
  • Have you written unit tests to cover this change?
  • Is unit test coverage still above 80%?
  • Have you updated all applicable documentation?
  • Have you followed the guidelines in our Contributing document?

@tpdownes tpdownes requested a review from mr0re1 March 28, 2023 19:18
@tpdownes tpdownes assigned tpdownes and unassigned mr0re1 Mar 28, 2023
@tpdownes tpdownes assigned mr0re1 and unassigned tpdownes Mar 28, 2023
@mr0re1 mr0re1 assigned tpdownes and unassigned mr0re1 Mar 28, 2023
@tpdownes tpdownes merged commit 721766f into GoogleCloudPlatform:develop Mar 28, 2023
@tpdownes tpdownes deleted the fix_references branch March 28, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr0re1 mr0re1 mr0re1 approved these changes

Assignees

@tpdownes tpdownes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpdownes @mr0re1