Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update small example to have same region and zone as high-io #123

Merged

Conversation

nick-stroud
Copy link
Collaborator

Submission Checklist:

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

@tpdownes
Copy link
Member

tpdownes commented Feb 23, 2022

@cboneti does this have any impact on integration tests? (or what the integration tests are intended to test)

@nick-stroud
Copy link
Collaborator Author

does this have any impact on integration tests? (or what the integration tests are intended to test)

@tpdownes, Integration test do not run examples/hpc-cluster-small.yaml. They run lustre-with-new-vpc.yaml and hpc-cluster-high-io.yaml, so this should have on effect.

@cboneti
Copy link
Member

cboneti commented Mar 1, 2022

No impact. But thanks for checking.

@nick-stroud nick-stroud merged commit 3454fdd into GoogleCloudPlatform:develop Mar 1, 2022
@nick-stroud nick-stroud deleted the unify_example_regions branch April 28, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants