Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filestore module should allow specification of project_id #125

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Filestore module should allow specification of project_id #125

merged 1 commit into from
Feb 25, 2022

Conversation

tpdownes
Copy link
Member

Right now, our Filestore module only supports provisioning an instance to the default project specified as the project_id global variable. There are situations where we might want to use a different project. In particular, when a Shared VPC is in use a Filestore instance must be in the host project to be accessible to all service projects.

Submission Checklist:

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

@tpdownes tpdownes merged commit 7752312 into GoogleCloudPlatform:develop Feb 25, 2022
@tpdownes tpdownes deleted the filestore_project_id branch February 25, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants