Bring resreader test coverage above 80% #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add high level function tests for resreader and cover more error handling cases. In addition, add unit tests to pre-commit coverage.
cboneti
approved these changes
Oct 21, 2021
nick-stroud
referenced
this pull request
in nick-stroud/hpc-toolkit
Jul 8, 2022
Creates Cloud Batch login node module
nick-stroud
pushed a commit
that referenced
this pull request
Aug 16, 2024
Go fix - package moved to archive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add high level function tests for resreader and cover more error
handling cases.
In addition, add unit tests to pre-commit coverage.
Coverage on develop:
ok hpc-toolkit/pkg/resreader (cached) coverage: 37.9% of statementsCoverage with this change:
ok hpc-toolkit/pkg/resreader (cached) coverage: 82.6% of statements