Bring config package unit tests past 80% coverage #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cboneti
reviewed
Oct 25, 2021
Update test for ExportYamlConfig so that it doesn't log fatal, but rather tests the created files info to validate it was created correctly.
|
@cboneti Feedback has been answered in the comments or addressed in the last commit. PTAL |
cboneti
approved these changes
Oct 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add and reorganize tests for the config package. Also includes a minor fix error messages in the resreader package tests.
developbranch coverage:ok hpc-toolkit/pkg/config (cached) coverage: 44.5% of statementsCoverage with this PR:
ok hpc-toolkit/pkg/config 0.035s coverage: 80.8% of statements