Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vm-instance instructions to handle the case that there are zero instances #1413

Conversation

nick-stroud
Copy link
Collaborator

Resolves one part of issue reported in #1405 where vm-instance fails on terraform apply when instance count is set to zero.

Manually tested with instance_count: 0.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@nick-stroud nick-stroud assigned nick-stroud and unassigned rohitramu Jun 6, 2023
@nick-stroud nick-stroud merged commit 69848ab into GoogleCloudPlatform:develop Jun 6, 2023
This was referenced Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants