Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove provider blocks from child modules #151

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Remove provider blocks from child modules #151

merged 1 commit into from
Mar 17, 2022

Conversation

tpdownes
Copy link
Member

Submission Checklist

It is a Terraform best practice to only define provider blocks in the root module and to pass providers implicitly or explicitly to child modules. This PR removes unnecessary/conflicting child module provider blocks.

Each resource in the configuration must be associated with one provider configuration. Provider configurations, unlike most other concepts in Terraform, are global to an entire Terraform configuration and can be shared across module boundaries. Provider configurations can be defined only in a root Terraform module.

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

@tpdownes tpdownes requested a review from heyealex March 17, 2022 03:54
@tpdownes tpdownes assigned tpdownes and heyealex and unassigned tpdownes Mar 17, 2022
@heyealex heyealex assigned tpdownes and unassigned heyealex Mar 17, 2022
@tpdownes tpdownes merged commit 08a60c0 into GoogleCloudPlatform:develop Mar 17, 2022
@tpdownes tpdownes deleted the remove_provider_blocks branch March 17, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants