Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pause between slurm srun tests #162

Merged

Conversation

heyealex
Copy link
Contributor

Submission Checklist

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

cboneti
cboneti previously approved these changes Mar 22, 2022
@heyealex
Copy link
Contributor Author

This worked overnight, I'm having issues kicking off another run this morning (Internal Error?). I'll try again shortly.

@heyealex heyealex marked this pull request as ready for review March 22, 2022 16:19
@tpdownes
Copy link
Member

tpdownes commented Mar 22, 2022

I would consider wait_for ansible resource. You could also do something like wait_for the existence of the job output file.

e.g.

- name: Sleep for 300 seconds and continue with play
  wait_for:
    timeout: 300
  delegate_to: localhost

- name: Wait until the file /tmp/foo is present before continuing
  wait_for:
    path: /tmp/foo

(I don't know what delegate_to is doing in this example)

@tpdownes
Copy link
Member

You might also consider some until and retry if the point is resiliency:

https://docs.ansible.com/ansible/latest/user_guide/playbooks_loops.html#retrying-a-task-until-a-condition-is-met

@heyealex heyealex merged commit 49ef79a into GoogleCloudPlatform:develop Mar 22, 2022
@heyealex heyealex deleted the add-pause-to-integration-tests branch March 22, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants