Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Shielded VM features to HTCondor modules #1704

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

tpdownes
Copy link
Member

This PR adds Shielded VM (Secure Boot and other features) support to the HTCondor modules and enables it in the example blueprint used by the tutorial.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@tpdownes tpdownes added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Aug 21, 2023
Copy link
Contributor

@harshthakkar01 harshthakkar01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: would be good to add more description as to what would be the impact of adding this to HTCondor module and why we need this.

@tpdownes tpdownes merged commit 1878b68 into GoogleCloudPlatform:develop Aug 21, 2023
5 of 24 checks passed
@tpdownes tpdownes deleted the htcondor_secure_boot branch August 21, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-module-improvements Added to release notes under the "Module Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants