Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startup-script to install Ops Agent #171

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Add startup-script to install Ops Agent #171

merged 2 commits into from
Mar 28, 2022

Conversation

mittz
Copy link
Contributor

@mittz mittz commented Mar 23, 2022

Add the startup-script script resources/scripts/startup-script/examples/install_cloud_ops_agent.sh to support users to install Ops Agent in VM which doesn't have any monitoring/logging agents if they would like. For more details on the test cases I covered, please refer to the ticket for this update.

Submission Checklist

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

@heyealex heyealex self-assigned this Mar 24, 2022
Copy link
Contributor

@heyealex heyealex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good and it's really cleanly implemented. My only comments on generalizing this a bit further.

@heyealex heyealex assigned mittz and unassigned heyealex Mar 24, 2022
@mittz
Copy link
Contributor Author

mittz commented Mar 25, 2022

Thank you for your review and comments. I expanded the condition similar to install_ansible.sh.

@mittz mittz requested a review from heyealex March 25, 2022 14:54
@cboneti cboneti assigned heyealex and unassigned mittz Mar 28, 2022
@cboneti cboneti assigned cboneti and heyealex and unassigned heyealex and cboneti Mar 28, 2022
@heyealex heyealex merged commit 5408731 into GoogleCloudPlatform:develop Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants