Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle filestore api as part of nightly cleanup #174

Merged

Conversation

nick-stroud
Copy link
Collaborator

@nick-stroud nick-stroud commented Mar 23, 2022

Prior to this change we will have to manually toggle the filestore api every 49 times we run integration tests ref.

If filestore is in use when job runs then api will not be disabled and cleanup job will succeed.

Tested:

  • Manually ran on cloud build.
  • Created a filestore, then ran cleanup job, then verified filestore was still present. (aka: will not force delete)

Submission Checklist

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

@cboneti cboneti assigned nick-stroud and unassigned cboneti Mar 23, 2022
Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little afraid of randomly waiting for a minute (unless they have an SLO around that), but I doubt we should invest much more time on this, so maybe just reorder the build steps a little so re-enabling is done last?

tools/cloud-build/project-cleanup.yaml Show resolved Hide resolved
@nick-stroud nick-stroud assigned cboneti and unassigned cboneti Mar 24, 2022
@cboneti cboneti assigned nick-stroud and unassigned cboneti Mar 24, 2022
@nick-stroud nick-stroud merged commit 4ab5ccf into GoogleCloudPlatform:develop Mar 24, 2022
@nick-stroud nick-stroud deleted the filestore_network_cleanup branch March 24, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants