Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin to address build error with TFLint #180

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Update plugin to address build error with TFLint #180

merged 1 commit into from
Mar 29, 2022

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Mar 28, 2022

The weekly integration test failed with tflint errors related to TFLint plugin incompatiblity with the Google provider. Various issues in TFLint repo suggest that upgrading our outdated version of the plugin will address this.

Submission Checklist

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

@tpdownes tpdownes requested a review from cboneti March 28, 2022 16:31
@tpdownes tpdownes assigned cboneti and unassigned cboneti Mar 28, 2022
@tpdownes
Copy link
Member Author

TL;DR: I believe this is ready to go. But, we will see issues again when tflint in our integration container is upgraded to 0.35.0 or above (this was just released). If so, we will need to upgrade TFLint plugin 0.16.0 (or higher)

The combination of 0.34.1 and 0.15.0 is good. The combination of 0.35.0 and 0.16.0 is good. No other recent combinations are good.

I think our containers are being built with 0.35.0 but when I see latest actually run in Cloud Build, it's picking up 0.34.1. I've done what I can to force-pull latest, but without success.

Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good, but since it is a very specific combination of versions, I wonder if we should document which tflint version is required. What do you think?

What do you think?

@tpdownes
Copy link
Member Author

tpdownes commented Mar 29, 2022

I think the right thing to do is to figure out why I'm seeing TFLint 0.34.1 in the actual builds when I believe the latest container should have 0.35.0. But, yes, once we do that, I'd upgrade to 0.16.0 and, at least, have a comment in the HCL file indicating the importance of aligning versions.

I have done what I can to figure out the version problem in Build. I don't know what to do from here about that.

@tpdownes tpdownes merged commit 6810843 into GoogleCloudPlatform:develop Mar 29, 2022
@tpdownes tpdownes deleted the fix_tflint_build_error branch March 29, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants